Thanks to visit codestin.com
Credit goes to github.com

Skip to content

UI Add milliseconds to elapsed time in progress bars - #34245

Merged
ogrisel merged 1 commit into
scikit-learn:mainfrom
jeremiedbb:ms-for-elapsed-time
Jun 12, 2026
Merged

UI Add milliseconds to elapsed time in progress bars#34245
ogrisel merged 1 commit into
scikit-learn:mainfrom
jeremiedbb:ms-for-elapsed-time

Conversation

@jeremiedbb

Copy link
Copy Markdown
Member

Fixes #34230

from sklearn.callback import ProgressBar
from sklearn.datasets import make_classification
from sklearn.linear_model import LogisticRegression

X, y = make_classification(n_samples=100000, n_features=100, n_informative=30, n_classes=10)

LogisticRegression(solver="lbfgs").set_callbacks(ProgressBar()).fit(X,y)
LogisticRegression - fit ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 0:00:01.645

I chose the keep the hours for now, I find it fine. Let me know what you think.

@ogrisel ogrisel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Shall we add a changelog entry?

@jeremiedbb

Copy link
Copy Markdown
Member Author

Shall we add a changelog entry?

really doesn't feel necessary :)

@ogrisel

ogrisel commented Jun 12, 2026

Copy link
Copy Markdown
Member

Alright, let's merge then.

@ogrisel
ogrisel merged commit 0ae7000 into scikit-learn:main Jun 12, 2026
42 checks passed
prady0t pushed a commit to prady0t/scikit-learn that referenced this pull request Sep 2, 2026
@jeremiedbb
jeremiedbb deleted the ms-for-elapsed-time branch September 3, 2026 15:25
@jeremiedbb jeremiedbb mentioned this pull request Sep 8, 2026
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UX] display more informative ellapsed time info in progress bar output for short tasks

2 participants