test: speed up two slow tests - #34269
Merged
Merged
Conversation
- test_calibrated_classifier_cv_works_with_large_confidence_scores: reduce n from 1000 to 200. The SGDClassifier never converges on the deliberately unscaled data, so the per-fit cost scales with n. A few hundred samples still reproduce the large confidence scores from issue 26766 across all seeds, dropping the worst-seed runtime from ~18s to ~1s. - test_cross_validate_params_none: run permutation_test_score with n_permutations=5 instead of the default 100; the test only exercises the params=None code path, so the permutation count is irrelevant.
rth
commented
Jun 12, 2026
| """ | ||
| prob = 0.67 | ||
| n = 1000 | ||
| n = 200 |
Member
Author
There was a problem hiding this comment.
Confirmed that this still works as a non regression test for the issue linked in the docstring.
ogrisel
approved these changes
Jun 12, 2026
ogrisel
enabled auto-merge (squash)
June 12, 2026 14:18
jeremiedbb
approved these changes
Jun 12, 2026
prady0t
pushed a commit
to prady0t/scikit-learn
that referenced
this pull request
Sep 2, 2026
jeremiedbb
pushed a commit
that referenced
this pull request
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A tiny fix to speed up the 2 slowest tests in CI:
before
after
So gains 18s on a 11min test suite run (maybe a bit more in CI). Small but non negligible.