MNT don't use random_state in LogisticRegression unless it has an effect - #34287
Merged
Conversation
AnneBeyer
approved these changes
Jun 16, 2026
Contributor
There was a problem hiding this comment.
Thank you, @lorentzenchr! I agree that it does not make sense to specify random_state in the tests and examples where it is not actually used.
Contributor
|
The linting problems should be fixed via #34300 now, merging |
OmarManzoor
approved these changes
Jun 17, 2026
OmarManzoor
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thank you @lorentzenchr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #34286.
What does this implement/fix? Explain your changes.
Removes
random_state=..inLogisticRegressionwhere it has no effect.First time contributor introduction
AI usage disclosure
None
Any other comments?