DOC fix incorrect default for random_state in estimate_bandwidth docstring - #34291
Conversation
|
Thank you for opening your first pull request to scikit-learn! 🎉 To help get your contribution reviewed, please make sure that:
|
StefanieSenger
left a comment
There was a problem hiding this comment.
Thanks for your doc fix, @Kropiunig.
Next, you have to fix the param_validation, too (you'll need to add StrOptions as a possible input for the random_state param).
|
Thanks for the review, @StefanieSenger. Before I touch the validation, could you confirm what you have in mind? Looking at the current code, |
Sorry @Kropiunig, not sure what I meant there. Your PR is good to go as is. |
…tring (scikit-learn#34291) Co-authored-by: Stefanie Senger <[email protected]>
…tring (scikit-learn#34291) Co-authored-by: Stefanie Senger <[email protected]>
The signature of
estimate_bandwidthusesrandom_state=0, but its docstring documentsdefault=None, which contradicts the actual behavior (deterministic subsampling by default). Thedefault=Nonetext dates to the 2020 docstring standardization (#16056). This corrects the docstring todefault=0; docstring-only, no behavior change.