FIX increase rtol in test_glm_regression_vstacked_X for solver newton-cg - #34323
Merged
lorentzenchr merged 8 commits intoJun 18, 2026
Merged
Conversation
test_glm_regression_vstacked_X
test_glm_regression_vstacked_X
lorentzenchr
approved these changes
Jun 17, 2026
lorentzenchr
enabled auto-merge (squash)
June 17, 2026 19:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #34316
What does this implement/fix? Explain your changes.
Set
rtolto1e-7intest_glm_regression_vstacked_Xfor solvernewton-cg(which is the same now as intest_glm_regression_hstacked_X).First time contributor introduction
AI usage disclosure
I used AI assistance for:
Any other comments?