ENH Newton-CD part 2: add early_stopping to CD solvers - #34336
Merged
OmarManzoor merged 3 commits intoJun 19, 2026
Conversation
Member
Author
|
@OmarManzoor Part 2. |
14 tasks
OmarManzoor
reviewed
Jun 19, 2026
OmarManzoor
left a comment
Contributor
There was a problem hiding this comment.
Only minor comment related changes otherwise this looks fine. Thank you @lorentzenchr
OmarManzoor
approved these changes
Jun 19, 2026
OmarManzoor
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thank you @lorentzenchr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Part 2 of #33160.
What does this implement/fix? Explain your changes.
This PR adds
early_stoppingto the private (Cython) coordinate descent solvers. If set to True, the CD checks convergence with the dual gap before entering the main iteration loop.This has no user impact, the current behavior is kept (functionality only for future purposes).
AI usage disclosure
None
Any other comments?