FIX radius_neighbors with array-like radius and n_jobs > 1 for tree-based algorithms - #34341
Merged
lesteve merged 3 commits intoAug 16, 2026
Merged
Conversation
|
Thank you for opening your first pull request to scikit-learn! 🎉 To help get your contribution reviewed, please make sure that:
|
Member
|
Actually, no: we need a changelog entry as reported by the CI. Here are the instructions: https://github.com/scikit-learn/scikit-learn/blob/main/doc/whats_new/upcoming_changes/README.md |
1 task
Contributor
Author
|
Thanks for the link, I added the missing changelog entry! |
Member
|
Merging this one, thanks! |
prady0t
pushed a commit
to prady0t/scikit-learn
that referenced
this pull request
Sep 2, 2026
…ased algorithms (scikit-learn#34341) Co-authored-by: Olivier Grisel <[email protected]>
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Sep 8, 2026
…ased algorithms (scikit-learn#34341) Co-authored-by: Olivier Grisel <[email protected]>
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Sep 9, 2026
…ased algorithms (scikit-learn#34341) Co-authored-by: Olivier Grisel <[email protected]>
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Sep 9, 2026
…ased algorithms (scikit-learn#34341) Co-authored-by: Olivier Grisel <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #34338
Towards #25970
What does this implement/fix? Explain your changes.
When
radiusis passed as a per-sample array,NearestNeighbors.radius_neighborsreturns a correct result withn_jobs=1but used to raise aValueErrorwithn_jobs>1on identical input for bothball_treeandkd_tree. This PR fixes that by slicingradiustogether with the already sliced dataXwhenradiusis not a scalar.