ENH Newton-CD part 3: Add compute_d2 to NewtonSolver - #34345
Merged
OmarManzoor merged 1 commit intoJun 22, 2026
Conversation
OmarManzoor
approved these changes
Jun 22, 2026
OmarManzoor
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thank you @lorentzenchr
Member
Author
|
🥳This is progressing fast🥳 |
14 tasks
prady0t
pushed a commit
to prady0t/scikit-learn
that referenced
this pull request
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Part 3 of #33160.
What does this implement/fix? Explain your changes.
This adds the method
compute_d2toNewtonSolversuch that future solvers (the ones in #33160) can deviate in the way they compute the Newton decrementd2.AI usage disclosure
None
Any other comments?