MNT: Fix CI for cython-lint 0.21 - #34359
Merged
Merged
Conversation
lorentzenchr
left a comment
Member
There was a problem hiding this comment.
Hmm. I am fine with this PR.
But I don’t like the _ variables too much (in Cython code).
ogrisel
approved these changes
Jun 22, 2026
ogrisel
left a comment
Member
There was a problem hiding this comment.
LGTM. I find this way of writing can explicitly convey that the iteration index is not used in the loop.
Member
From Python perspective: Yes 👍. From a C perspective: I haven't seen it (yet). |
prady0t
pushed a commit
to prady0t/scikit-learn
that referenced
this pull request
Sep 2, 2026
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Closes #34356
Very similar to #34331
What does this implement/fix? Explain your changes.
for _ in range(...)syntax).