CI Fix uninitialised memory at exactly x=0.35 - #34373
Merged
Merged
Conversation
This is a very unlikely case but cheap to fix.
ogrisel
approved these changes
Jun 23, 2026
Co-authored-by: Olivier Grisel <[email protected]>
prady0t
pushed a commit
to prady0t/scikit-learn
that referenced
this pull request
Sep 2, 2026
Co-authored-by: Olivier Grisel <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very unlikely case but cheap to fix. The point
fX == 0.35isn't covered by any of the assignments. So theoretically you could end up with uninitialised memory.This is a follow up to #34371. I asked AI to look at all the tests in the project to see if there are any other occurrences of
np.emptythat should be fixed. It found several uses ofnp.empty/np.empty_like(about 40) but thinks that this is the only case where the array isn't immediately filled with values.I didn't check all of the ones it did not change to see if it got all of them right. Given that we don't suffer more flakyness in our tests I think that would be too much effort.
(Could have also changed the condition in the assignments to make a
<into a<=)AI usage disclosure
I used AI assistance for: