DOC fix typo and inconsistencies in RidgeClassifier docstrings - #34402
Conversation
|
Closes #34401 |
|
Please take the time to fill in the PR description and resolve the linter errors. Otherwise this looks reasonable to me. Thanks for finding and fixing the typos |
|
Thank you for the feedback. I have updated the PR description. |
AnneBeyer
left a comment
There was a problem hiding this comment.
Hi @vashita-pandey, thank you for the fixes. I can confirm that the linting errors are unrelated (and should go away if you merge main into your branch again).
Just one note on the procedure: The idea behind opening an issue first is that a maintainer can mark it as ready for contribution once it is triaged and discussed (we currently have >1.5k open issues, so we need to be selective on what is worth the reviewing time). You opened this PR while the issue was still labelled “Needs triage”.
On the other hand, fixing typos doesn't necessarily require opening an issue first, so I would be fine with merging this one anyway, @betatim.
|
@AnneBeyer |
|
I merged I recommend for typo fixes like this to not open an issue first. For everything else it is good practice to open an issue first and wait for the discussion to settle on what to do and if it is worth doing. There are many things that could be done and would be improvements, but for other reasons we decide against doing them. |
|
I enabled automerge, if merging |
|
Need to approve for auto merge to work ... |
…t-learn#34402) Co-authored-by: Tim Head <[email protected]>
…t-learn#34402) Co-authored-by: Tim Head <[email protected]>
Closes #34401
What does this fix?
Fixes several docstring issues in sklearn/linear_model/_ridge.py:
to match the formatting already used in Ridge