🔒 🤖 CI Update lock files for lint CI build(s) 🔒 🤖#34405
🔒 🤖 CI Update lock files for lint CI build(s) 🔒 🤖#34405scikit-learn-bot wants to merge 1 commit into
Conversation
|
@AnneBeyer do you understand why this changes the cython-lint version? Though after looking at the PR that added the lockfile I am now wondering why it was version 0.20 in the lockfile before this PR. The version in xref #34303 |
ogrisel
left a comment
There was a problem hiding this comment.
Those version values are in line with the contents of build_tools/update_environments_and_lock_files.py and sklearn/_min_dependencies.py.
I think we just forgot to rerun the lockfile script before merging the PR...
AnneBeyer
left a comment
There was a problem hiding this comment.
I think we just forgot to rerun the lockfile script before merging the PR...
Indeed. I updated the cython-lint version again after we had fixed the errors with the newest release, but didn't run build_tools/update_environments_and_lock_files.py again locally, which creates the two files that were changed in this PR.
| # pip-compile --output-file=build_tools/github/lint_lock.txt build_tools/github/lint_requirements.txt | ||
| # | ||
| cython==3.2.5 | ||
| cython==3.2.6 |
There was a problem hiding this comment.
Should we actually lock the dependent cython version as well?
There was a problem hiding this comment.
I merged #34419 and now we need to resolve the conflict.
There was a problem hiding this comment.
The bot (force) pushed an update to this PR. That "resolved" the conflict, or did you mean a conflict in a different PR?
088280a to
9e49db0
Compare
Update lock files.
Note
If the CI tasks fail, create a new branch based on this PR and add the required fixes to that branch.