MAINT: Remove Sass dependency - as css accepts nesting and & - #34413
Merged
Conversation
DeaMariaLeon
commented
Jul 1, 2026
DeaMariaLeon
commented
Jul 1, 2026
DeaMariaLeon
commented
Jul 1, 2026
DeaMariaLeon
commented
Jul 1, 2026
DeaMariaLeon
commented
Jul 1, 2026
DeaMariaLeon
marked this pull request as ready for review
July 1, 2026 11:26
&&
Member
Author
|
Friendly ping to @Charlie-XIAO, @betatim in case you have time/interest in reviewing. |
betatim
reviewed
Jul 7, 2026
betatim
approved these changes
Jul 7, 2026
betatim
left a comment
Member
There was a problem hiding this comment.
This looks good to me. WIth my modern browser I couldn't find any visual regressions.
Would be good to hear from @Charlie-XIAO who knows more about the docs page and HTML/CSS
Charlie-XIAO
approved these changes
Jul 7, 2026
Charlie-XIAO
left a comment
Contributor
There was a problem hiding this comment.
LGTM, I didn't check the dependencies but all CSS changes look equivalent to me. Just one nitpick below.
Member
Author
|
Thanks a lot! |
lucyleeow
pushed a commit
to lucyleeow/scikit-learn
that referenced
this pull request
Jul 9, 2026
prady0t
pushed a commit
to prady0t/scikit-learn
that referenced
this pull request
Sep 2, 2026
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Closes #34414
What does this implement/fix? Explain your changes.
Remove Sass dependency.
css accepts nesting without the need of a preprocessor.
Note to myself: I may need to update lock files (?)
First time contributor introduction
AI usage disclosure
I used AI assistance for:
Any other comments?