DOC Fix typos and improve wording in plot_cost_sensitive_learning.py - #34417
Merged
Conversation
AnneBeyer
commented
Jun 30, 2026
|
|
||
| # %% | ||
| # We observe that we obtained the exact same results but the fitting process | ||
| # was much faster since we did not perform any hyper-parameter search. |
Contributor
Author
There was a problem hiding this comment.
Once supported, this point could even be illustrated by a progress bar. ;)
Contributor
There was a problem hiding this comment.
haha, i would actually love to see a progress bar for this! Maybe your next PR? :)
shipitdev
approved these changes
Jun 30, 2026
shipitdev
left a comment
Contributor
There was a problem hiding this comment.
the grammer & flow looks clean along with the pandas.plot.hist swap. Thank you @AnneBeyer LGTM :)
betatim
reviewed
Jun 30, 2026
betatim
reviewed
Jun 30, 2026
betatim
reviewed
Jun 30, 2026
betatim
approved these changes
Jun 30, 2026
betatim
left a comment
Member
There was a problem hiding this comment.
Spotted a few more chances for improvement. Once they are dealt with we can merge this
Co-authored-by: Tim Head <[email protected]>
ogrisel
approved these changes
Jun 30, 2026
prady0t
pushed a commit
to prady0t/scikit-learn
that referenced
this pull request
Sep 2, 2026
scikit-learn#34417) Co-authored-by: Tim Head <[email protected]>
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Sep 9, 2026
scikit-learn#34417) Co-authored-by: Tim Head <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Noticed while working through the example Post-tuning the decision threshold for cost-sensitive learning
What does this implement/fix? Explain your changes.
Fixes typos, makes small wording changes to improve clarity and optimizes the code slightly.
AI usage disclosure
I used AI assistance for:
Any other comments?