TST Remove non-functional test_ridge_loo_cv_asym_scoring (#16041)#34422
Draft
dhruv7477 wants to merge 2 commits into
Draft
TST Remove non-functional test_ridge_loo_cv_asym_scoring (#16041)#34422dhruv7477 wants to merge 2 commits into
dhruv7477 wants to merge 2 commits into
Conversation
Contributor
Author
|
This is a test-only fix (correcting test_ridge_loo_cv_asym_scoring) with no user-facing behavior or API change, so no changelog entry is needed. Could a maintainer add the No Changelog Needed label to satisfy the changelog check? |
Member
|
I think we should just remove this useless test. |
eacff42 to
8726ea7
Compare
Contributor
Author
|
@ogrisel Agreed — removed the test. Thanks! |
Contributor
Author
|
@ogrisel Done — removed the test as suggested; it's now a pure deletion. I've left it as a draft because I've hit the "ready for review" PR limit (my other open PR #33879 is using the slot), so I can't flip this to ready myself. Since this is just the removal you requested, could a maintainer mark it ready / take it from here? Happy to adjust anything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #16041.
What does this implement/fix?
Removes
test_ridge_loo_cv_asym_scoring. As reported in #16041, it did not test anything meaningful: it comparedRidgeCV(cv=n_samples, scoring="explained_variance")against the GCV path, but with leave-one-out each fold has a single sample andexplained_varianceon one sample is degenerate, so every alpha tied and the test passed by chance. Per maintainer suggestion, removing it rather than rewriting.