DOC Fix HTML in contributing.rst page - #34485
Merged
Merged
Conversation
DeaMariaLeon
marked this pull request as ready for review
July 15, 2026 17:46
contributing.rst pagecontributing.rst page
prady0t
pushed a commit
to prady0t/scikit-learn
that referenced
this pull request
Sep 2, 2026
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
No issue. I found it while commenting #34239 (comment)
What does this implement/fix? Explain your changes.
The #contributing anchor is gone because a block was added between a label and the title of the page.
Currently, in main, the reference is linked to the hidden raw text:
scikit-learn/doc/developers/contributing.rst
Lines 1 to 23 in bb9df11
1) With that, Sphinx ends up computing a generic id to the page (
id1) in the resulting HTML:That means that other pages that link to
contributingwill not work if the rst page structure changes.2)With this PR, the correct name is linked to the right reference:
Please see https://www.sphinx-doc.org/en/master/usage/referencing.html#role-ref for more info.
One can see that the label must be right before the title.
AI usage disclosure
Any other comments?
I just moved the block out of the way.