Make common test_check_targets_array_api - #34487
Merged
Merged
Conversation
Member
Author
|
cc @OmarManzoor |
OmarManzoor
approved these changes
Jul 16, 2026
OmarManzoor
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thank you @lucyleeow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
As discussed in #33778 (comment)
What does this implement/fix? Explain your changes.
Make
test__check_reg_targets_array_apia common test for both_check_targetsandcheck_reg_targetsand move totest_common.py.Fix
_check_targetssuch thaty_predis also moved ifxpanddeviceis passed (and not the same xp and device as y_pred). Note that this is a corner case, and never occurs in our code, so no changelog needed.AI usage disclosure
I used AI assistance for:
Any other comments?