Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC Clarify right to contribute and paid-platform disclosure - #34490

Merged
StefanieSenger merged 9 commits into
scikit-learn:mainfrom
StefanieSenger:fix_legal_ai_issue
Aug 28, 2026
Merged

DOC Clarify right to contribute and paid-platform disclosure#34490
StefanieSenger merged 9 commits into
scikit-learn:mainfrom
StefanieSenger:fix_legal_ai_issue

Conversation

@StefanieSenger

@StefanieSenger StefanieSenger commented Jul 16, 2026

Copy link
Copy Markdown
Member

Reference Issues/PRs

towards #34489

What does this implement/fix? Explain your changes.

  • educate users that if they sold their copyright of the PR code to a paid platform, they cannot contribute it to scikit-learn
  • require disclosure if submitted code was done for a third-party paid platform

AI usage disclosure

I used AI assistance for:

  • Documentation (including examples)
  • Research and understanding

@StefanieSenger StefanieSenger changed the title MNT Clarify right to contribute and paid-platform disclosure DOC Clarify right to contribute and paid-platform disclosure Jul 16, 2026
Comment thread doc/developers/contributing.rst
@github-project-automation github-project-automation Bot moved this to Todo in Labs Jul 20, 2026
@StefanieSenger StefanieSenger moved this from Todo to PR waiting for reviews in Labs Jul 20, 2026
@StefanieSenger

Copy link
Copy Markdown
Member Author

@DeaMariaLeon, would you mind having a closer look?

Comment thread doc/developers/contributing.rst Outdated
===================

Pull requests are accepted under the project's `BSD 3-Clause
License<https://github.com/scikit-learn/scikit-learn/blob/main/COPYING>`_. By opening a

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a space between License and < .
Docs if needed

Comment thread doc/developers/contributing.rst Outdated
If the work was done for a third-party paid platform (for example bounties,
paid "quests", or similar programs that compensate you for opening PRs or producing
training data), state so. Do not use scikit-learn's review process as unpaid QA for an
external company.

@DeaMariaLeon DeaMariaLeon Jul 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel that there is some repetition on lines 166-170 versus 184-189. Then, there is right to contribute later.

So, if one reads the whole contributing document, there are 3 places talking about this.
Maybe if you do want to repeat, merge 2 paragraphs in one (with a very short version) and link to the longer one right to contribute?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, fair enough. I have merged both paragraphs from "Automated Contributions Policy" into one.

@StefanieSenger StefanieSenger left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @DeaMariaLeon, I have implemented your suggestions.

Comment thread doc/developers/contributing.rst Outdated
If the work was done for a third-party paid platform (for example bounties,
paid "quests", or similar programs that compensate you for opening PRs or producing
training data), state so. Do not use scikit-learn's review process as unpaid QA for an
external company.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, fair enough. I have merged both paragraphs from "Automated Contributions Policy" into one.

@DeaMariaLeon DeaMariaLeon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @StefanieSenger!

Now you need someone with real powers. 🪄

@StefanieSenger StefanieSenger added the Waiting for Second Reviewer First reviewer is done, need a second one! label Jul 23, 2026
Comment thread .github/PULL_REQUEST_TEMPLATE.md Outdated
Comment on lines +48 to +57
#### Right to contribute
<!--
Edit the list below.
-->
This work was done for a third-party paid platform (bounty, paid quest, or similar):
- Yes (briefly name the platform)
- No

I have the right to license this contribution under the BSD 3-Clause License (I own it,
or I am authorized to contribute it).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking that we don't necessarily need to request to ask if it was for a third-party platform.

I would rather request to tick a checkbox in the template.

Comment thread doc/developers/contributing.rst Outdated
Comment on lines +23 to +28
### Paid platforms and licensing: Contributors must have the right to license
their contribution under the BSD 3-Clause License. Disclose in the PR
description if the work was done for a third-party paid platform (bounties,
"quests", or similar). Do not use scikit-learn's review process as unpaid QA for
external programs. See the Automated Contributions Policy and Right to
contribute sections in the contributing guide.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would dissociate the licensing from the unpaid QA. I think that both can be mentioned however.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, these are now two separate sections.

@betatim

betatim commented Jul 28, 2026

Copy link
Copy Markdown
Member

Two thoughts on this:

  1. it is annoying to be doing this kind of unpaid labour, in particular without knowing it
  2. our contributing docs and PR template are getting ever longer and more overwhelming to read

I'm not sure what to do about 1, beyond what we already do: close PRs and issues that seem to be low effort and not solving a problem we care about (at the moment). I'm wondering if we need a special case for this kind of low effort and priority work, or if we need to get a bit more organised internally to make sure everyone knows what is "low priority" and feels confident to close those contributions with little mental overhead.

My assumption is that abusive people will either not read our contributing docs or simply tick "the right boxes" to allow them to proceed. By having big text walls and "legal" questions we then put off the conscientious contributors. For example, having to fill out a CLA makes it quite a bit harder to make a contribution: I now have to explicitly deal with this topic, it contains legal text, I probably ave to involve my employer (and their lawyers) who often have never seen a CLA before in their life, etc. At best this means weeks pass before someone can contribute, at worst the lawyers do what lawyers do: if in doubt say no.

I think we should be fine, if we make a reasonable effort to inform people about the licensing requirement, individual contributors make a reasonable effort to inform themselves/figure out their legal situation and we are responsive when someone later comes to point out that something went wrong.

TL;DR: I like the information about the licensing in the various contributor guide, FAQ, etc documents. I would remove the FAQ and paragraph text specific to "are you doing this for a bounty?".


Related to my discussion about https://github.com/openclaw/clawsweeper with a friend, he pointed out that they use a bot to ask contributors to point to evidence that this is a useful/welcome contribution. For example, they can link to existing issue(s) where maintainers have said "yes do this" or reddit threads or such to proove that there is a "real reason" for this contribution. I think this is a cool idea, maybe not using a bot for it, but the "please include material to convince us". Maybe going in this direction will also reduce the number of "bounty" contributions that are not also useful for the project. Concretely: ask contributors to include proof that this is a useful contribution.

Comment thread .github/PULL_REQUEST_TEMPLATE.md Outdated
- Documentation (including examples)
- Research and understanding

#### Right to contribute

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove this section. For years it has worked well across the majority of the whole open-source ecosystem. Not sure we need this now, nor that it will solve the problem that triggered this. At worst people will just say yes or maybe the contracts they have signed explicitly contain a clause about this?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed it.

Comment thread doc/developers/contributing.rst Outdated
Comment on lines +179 to +184
Do not open pull requests mainly to meet the requirements of a third-party paid platform
(for example a bounty or paid "quest", or similar programs that compensate you for
opening PRs or producing training data). Do not use scikit-learn's review process as
unpaid QA for an external company. If that platform's terms assign copyright in your
work to them, you may no longer be allowed to contribute it under the BSD 3-Clause
License to scikit-learn; see :ref:`right_to_contribute`.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove this

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed it.

Comment thread doc/developers/contributing.rst Outdated

.. _right_to_contribute:

Right to contribute

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love "right to contribute" - everyone should feel like they can contribute. Contributing isn't some kind of right you gain. These are the first places where my mind goes when I read this title.

How about "Licensing requirement" or "License granting" or "Licensing your contribution"?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great suggestions. I have gone with "Licensing your contribution" which is the most descriptive, I think.

Comment thread doc/developers/contributing.rst Outdated
Pull requests are accepted under the project's `BSD 3-Clause
License <https://github.com/scikit-learn/scikit-learn/blob/main/COPYING>`_. By opening a
pull request, you must have the **legal right to grant that license** for every part of
your contribution.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
your contribution.
License <https://github.com/scikit-learn/scikit-learn/blob/main/COPYING>`_.
You must have the **legal right to grant that license** for every part of

"By opening ... you must have the right" is a strange formulation. "By doing X you must have the right Y". Maybe a better formulation would be "In order to open a PR, you must have the right" or "In order for your PR to be merged you must have the right". In the end I think we can just remove the first part

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the grammar review :) I have applied this.

Comment thread doc/faq.rst Outdated
:ref:`known issues <new_contributors>`. Please do not contact the contributors
of scikit-learn directly regarding contributing to scikit-learn.

Do I need special rights to contribute code under the BSD license?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit unhappy about how this is formulated. IMHO you don't need special rights, anyone can contribute and has the rights required to do so. Unless you have signed an agreement to the contrary.

The natural state of the universe is that you can contribute and grant the license.

So I'd try to formulate this as "When can I not contribute under the BSD license?" or "Are there cases where I can not contribute?"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed this entirely. I think it is not a frequently asked question anyway, and we already have this in the contribution guide.

@betatim

betatim commented Jul 28, 2026

Copy link
Copy Markdown
Member

Having thought about this a bit more, I think I am against making contributors sign a CLA/tick a box/variation of this.

I'm not sure it will help reduce the "contribution for money" problem and it will add a hurdle for good contributors.

On a more philosophical note, sustainable open-source is about exchanging value between maintainers and contributors. There has to be "something in it" for both sides for the project to continue for a long time. If a contributor can get paid for their work that is great, it is the simplest way to benefit from the contribution. You can exchange the money for basically anything else you might need. Things like fame&recognition which is often what contributors gain are much harder to exchange for other things.

What is missing from the "solve problems for AI training" problem we are discussing/reacting to here is the value for the project. The ideal contribution would be something where the contributor gets paid and the project benefits as well. If someone then also trains a LLM on this doesn't bother me. We are all benefitting/the rising tide lifts all the boats. So I am thinking that we should work more on how to evaluate the "benefit for the project" part. Asking contributors to show why their contribution is useful, having a clearer way to decide as a maintainer, etc. I think this is a harder task, but the thing we should focus on.

@StefanieSenger

StefanieSenger commented Jul 31, 2026

Copy link
Copy Markdown
Member Author

Having thought about this a bit more, I think I am against making contributors sign a CLA/tick a box/variation of this.

I've only read this after answering to Gael's suggestion here: #34489 (comment) earlier today.
I will treat your reply as a maintainer veto and close this PR if you don't thing anything is worth keeping. Please let me know in case you're okay with keeping anything from this PR, in particular this:

Do not open pull requests mainly to meet the requirements of a third-party paid platform
(for example a bounty or paid "quest", or similar programs that compensate you for
opening PRs or producing training data). Do not use scikit-learn's review process as
unpaid QA for an external company.

The ideal contribution would be something where the contributor gets paid and the project benefits as well. If someone then also trains a LLM on this doesn't bother me. We are all benefitting/the rising tide lifts all the boats.

I don't believe in the "the tide lifts all the boats" narrative. The expense open source projects pay is dedicating too much attention to contributions whose economic interests remain hidden. If it were all open and clearly communicated, my assessment would be very different.

@betatim

betatim commented Aug 3, 2026

Copy link
Copy Markdown
Member

I would keep the entry in the FAQ and the later part in the contributing guide. My only thought there is if we could find a different formulation than "right to contribute".

@StefanieSenger StefanieSenger left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have now removed many things and kept only the "right to contribute" section, but with the new title "Licensing your contribution" and the hidden section hat we have (<div style="display: none;">) that intends to talk to agents directly.

Would you like to have another look @betatim?

Comment thread doc/developers/contributing.rst Outdated

.. _right_to_contribute:

Right to contribute

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great suggestions. I have gone with "Licensing your contribution" which is the most descriptive, I think.

Comment thread doc/developers/contributing.rst Outdated
Pull requests are accepted under the project's `BSD 3-Clause
License <https://github.com/scikit-learn/scikit-learn/blob/main/COPYING>`_. By opening a
pull request, you must have the **legal right to grant that license** for every part of
your contribution.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the grammar review :) I have applied this.

Comment thread doc/faq.rst Outdated
:ref:`known issues <new_contributors>`. Please do not contact the contributors
of scikit-learn directly regarding contributing to scikit-learn.

Do I need special rights to contribute code under the BSD license?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed this entirely. I think it is not a frequently asked question anyway, and we already have this in the contribution guide.

Comment thread .github/PULL_REQUEST_TEMPLATE.md Outdated
- Documentation (including examples)
- Research and understanding

#### Right to contribute

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed it.

Comment thread doc/developers/contributing.rst Outdated
Comment on lines +23 to +28
### Paid platforms and licensing: Contributors must have the right to license
their contribution under the BSD 3-Clause License. Disclose in the PR
description if the work was done for a third-party paid platform (bounties,
"quests", or similar). Do not use scikit-learn's review process as unpaid QA for
external programs. See the Automated Contributions Policy and Right to
contribute sections in the contributing guide.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, these are now two separate sections.

Comment thread doc/developers/contributing.rst Outdated
Comment on lines +179 to +184
Do not open pull requests mainly to meet the requirements of a third-party paid platform
(for example a bounty or paid "quest", or similar programs that compensate you for
opening PRs or producing training data). Do not use scikit-learn's review process as
unpaid QA for an external company. If that platform's terms assign copyright in your
work to them, you may no longer be allowed to contribute it under the BSD 3-Clause
License to scikit-learn; see :ref:`right_to_contribute`.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed it.

@betatim betatim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

Thanks for the iterations!

@StefanieSenger

Copy link
Copy Markdown
Member Author

Great, I will merge it then (since we have two approvals).

@StefanieSenger
StefanieSenger merged commit f2e0b23 into scikit-learn:main Aug 28, 2026
37 checks passed
@github-project-automation github-project-automation Bot moved this from PR waiting for reviews to Done in Labs Aug 28, 2026
@StefanieSenger
StefanieSenger deleted the fix_legal_ai_issue branch August 28, 2026 12:28
prady0t pushed a commit to prady0t/scikit-learn that referenced this pull request Sep 2, 2026
@jeremiedbb jeremiedbb mentioned this pull request Sep 8, 2026
14 tasks
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Sep 8, 2026
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Sep 8, 2026
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Sep 8, 2026
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Sep 9, 2026
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Waiting for Second Reviewer First reviewer is done, need a second one!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants