Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC Improve documentation of safe_mask - #34508

Merged
StefanieSenger merged 1 commit into
scikit-learn:mainfrom
akshitasure12:doc/safe-mask-docstring
Jul 18, 2026
Merged

DOC Improve documentation of safe_mask#34508
StefanieSenger merged 1 commit into
scikit-learn:mainfrom
akshitasure12:doc/safe-mask-docstring

Conversation

@akshitasure12

Copy link
Copy Markdown
Contributor

Fixes #34505

Clarify the safe_mask docstring by improving the function summary from:

Return a mask which is safe to use on X.

to:

Return an indexing mask compatible with X.

@github-actions

Copy link
Copy Markdown

Thank you for opening your first pull request to scikit-learn! πŸŽ‰

To help get your contribution reviewed, please make sure that:

  • You have filled out the pull request template.
  • The pull request addresses an existing issue that is ready for
    contribution (e.g. not tagged as "Needs Triage", "Needs Decision", ...).
    If you are proposing a new feature, please open an issue to discuss it first.
  • There are no other open pull requests already targeting the same issue.
  • You have followed the pull request checklist.
    In particular, linting and tests should pass.

@StefanieSenger StefanieSenger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks pretty fine, thanks a lot! I will enable auto-merge.

And congrats on your first contribution to scikit-learn! πŸŽ‰ πŸŽ‰ πŸŽ‰

@StefanieSenger
StefanieSenger marked this pull request as ready for review July 18, 2026 09:28
@StefanieSenger
StefanieSenger enabled auto-merge (squash) July 18, 2026 09:29
@StefanieSenger
StefanieSenger merged commit 25088e0 into scikit-learn:main Jul 18, 2026
42 checks passed
prady0t pushed a commit to prady0t/scikit-learn that referenced this pull request Sep 2, 2026
@jeremiedbb jeremiedbb mentioned this pull request Sep 8, 2026
14 tasks
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve documentation of safe_mask

2 participants