MNT add CD_Algo enum to coordinate descent - code simplification - #34514
Merged
Conversation
Member
Author
|
@virchan friendly ping. |
virchan
approved these changes
Jul 25, 2026
virchan
left a comment
Member
There was a problem hiding this comment.
Thank you for fixing the CI, @lorentzenchr!
Merging to main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
None
What does this implement/fix? Explain your changes.
This PR adds
class CD_Algo(Enum)to coordinate descent code to simplify code logic, in particular inside the main loop indef enet_path.AI usage disclosure
None
Any other comments?
This will ease a follow-up PR to improve fit speed (again).