DOC Refactor plot_kmeans_digits.py to use DecisionBoundaryDisplay - #34515
Merged
StefanieSenger merged 6 commits intoJul 21, 2026
Merged
Conversation
5 tasks
Contributor
|
@mcvincekova, would you be interested in reviewing this one? |
lisaleemcb
marked this pull request as ready for review
July 19, 2026 12:23
Contributor
|
Thank you @lisaleemcb, LGTM! @StefanieSenger, could you have a look as well? |
AnneBeyer
approved these changes
Jul 19, 2026
mcvincekova
approved these changes
Jul 19, 2026
Comment on lines
+165
to
+166
| # Put the result into a color plot | ||
| Z = Z.reshape(xx.shape) | ||
| plt.figure(1) | ||
| plt.clf() | ||
| plt.imshow( | ||
| Z, | ||
| interpolation="nearest", | ||
| extent=(xx.min(), xx.max(), yy.min(), yy.max()), | ||
| cmap=plt.cm.Paired, | ||
| aspect="auto", | ||
| origin="lower", | ||
| DecisionBoundaryDisplay.from_estimator( |
Contributor
There was a problem hiding this comment.
[Nitpick] I find the comment # Put the result into a color plot a bit generic,
maybe something along the lines of: # Plot the K-means decision regions would be more informative?
Member
There was a problem hiding this comment.
I think we don't need this comment at all anymore.
StefanieSenger
left a comment
Member
There was a problem hiding this comment.
Thanks for your work, @lisaleemcb! :)
I've left a few comments as well.
Comment on lines
+165
to
+166
| # Put the result into a color plot | ||
| Z = Z.reshape(xx.shape) | ||
| plt.figure(1) | ||
| plt.clf() | ||
| plt.imshow( | ||
| Z, | ||
| interpolation="nearest", | ||
| extent=(xx.min(), xx.max(), yy.min(), yy.max()), | ||
| cmap=plt.cm.Paired, | ||
| aspect="auto", | ||
| origin="lower", | ||
| DecisionBoundaryDisplay.from_estimator( |
Member
There was a problem hiding this comment.
I think we don't need this comment at all anymore.
StefanieSenger
left a comment
Member
There was a problem hiding this comment.
Thank you @lisaleemcb, let's
- figure out the colour map with @AnneBeyer,
- also add a
random_statetoKMeanswhile we're at it, so we get the same plot ever time (we try to keep our examples deterministic, unless we want to demonstrate non-deterministic behaviour)
Then this can get merged. :)
StefanieSenger
approved these changes
Jul 21, 2026
StefanieSenger
left a comment
Member
There was a problem hiding this comment.
This now looks great! Thank you for your work, @lisaleemcb!
StefanieSenger
enabled auto-merge (squash)
July 21, 2026 20:18
prady0t
pushed a commit
to prady0t/scikit-learn
that referenced
this pull request
Sep 2, 2026
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Sep 9, 2026
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ In particular following the pull request checklist will increase the likelihood
of having maintainers review your PR:
https://scikit-learn.org/dev/developers/contributing.html#pull-request-checklist
Reference Issues/PRs
Addresses #33980 . See also #33119 .
What does this implement/fix? Explain your changes.
Updated the plot in the example using K-mean on digits dataset to use the
DecisionBoundaryDisplay.