MNT Remove unused extra_requires from pyproject.toml - #34544
Conversation
There was a problem hiding this comment.
Thanks for this clean-up PR! Let's merge this one since @thomasjpfan agreed that it was fine to remove the extra_requires.
Full disclosure: I don't think this is worth a changelog entry, because nobody seems to use the extra_requires according to the GitHub search in #34537. If someone strongly disagrees, PR more than welcome 😉!
I agree that the table is a bit confusing in this part of the doc which is more for users so listing build dependencies does not make too much sense ... Maybe the table in the user-facing doc would only show Having said this, I don't think this is very high at the top of our priority list 😅. |
Reference Issues/PRs
Closes #34537
What does this implement/fix? Explain your changes.
Removes the
[project.optional-dependencies]extras (build,install,benchmark,docs,examples,tests,maintenance) frompyproject.toml. See why in the issue.Also:
tag_to_packagesinverse mapping insklearn/_min_dependencies.py. It was already dead code sincesetup.py'sextras_require(its only consumer) was removed in BLD Remove support for setuptools build #29400.sklearn/tests/test_min_dependencies_readme.py->test_min_dependencies_consistency.pybecause it tests consistency ofsklearn/_min_dependencies.pyagainst the doc and thepyproject.toml.project.optional-dependencies.*sectionsAI usage disclosure
I used AI assistance for:
Follow-up question
Tags in
dependent_packagesare now used this way:pyproject.toml