Thanks to visit codestin.com
Credit goes to github.com

Skip to content

CI Add hint about optional CI to lockfile update bot message - #34552

Merged
lesteve merged 1 commit into
scikit-learn:mainfrom
betatim:update-lockfile-bot-comment-round2
Jul 23, 2026
Merged

CI Add hint about optional CI to lockfile update bot message#34552
lesteve merged 1 commit into
scikit-learn:mainfrom
betatim:update-lockfile-bot-comment-round2

Conversation

@betatim

@betatim betatim commented Jul 23, 2026

Copy link
Copy Markdown
Member

Follow up to #34546 (comment)

The goal is to make it easier for the human who looks at the lockfile update PR to know what they need to include in their commit message to get the right kinds of CI to run.

cc @lesteve

Help the human who might take over the PR get the right commit message
for optional CI runs.
### Note
If the CI tasks fail, create a new branch based on this PR and add the required fixes to that branch.
Prefer re-running the same command above (with the matching `--select-tag`) rather than updating all lock files.
${{ matrix.additional_commit_message && format('Remember to include `{0}` in your commit message so that the optional CI build runs.', matrix.additional_commit_message) || '' }}

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL that GitHub workflows have a ternary operator thing! Thanks AI :D

@lesteve lesteve left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good, thanks! We should remember to double whether it works on the next run on Monday

@lesteve
lesteve merged commit 09d631b into scikit-learn:main Jul 23, 2026
42 checks passed
@betatim
betatim deleted the update-lockfile-bot-comment-round2 branch July 23, 2026 11:05
prady0t pushed a commit to prady0t/scikit-learn that referenced this pull request Sep 2, 2026
@jeremiedbb jeremiedbb mentioned this pull request Sep 8, 2026
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants