Thanks to visit codestin.com
Credit goes to github.com

Skip to content

MNT Xfail multithreaded test on WASM - #34555

Merged
lesteve merged 2 commits into
scikit-learn:mainfrom
StefanieSenger:xfail_wasm_multithreaded
Jul 23, 2026
Merged

MNT Xfail multithreaded test on WASM#34555
lesteve merged 2 commits into
scikit-learn:mainfrom
StefanieSenger:xfail_wasm_multithreaded

Conversation

@StefanieSenger

@StefanieSenger StefanieSenger commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Reference Issues/PRs

fixes #34542

What does this implement/fix? Explain your changes.

This xfails a test that fails to start a thread when build with pyodide.

AI usage disclosure

I used AI assistance for:

  • Research and understanding

lesteve
lesteve approved these changes Jul 23, 2026
View reviewed changes

@lesteve lesteve left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! I'll set auto-merge.

@lesteve
lesteve merged commit 3e36503 into scikit-learn:main Jul 23, 2026
46 of 48 checks passed
@lesteve

lesteve commented Jul 23, 2026

Copy link
Copy Markdown
Member

Oops I forgot that Pyodide CI is not a "required check" so the PR was merged right away. I am reasonably confident that Pyodide CI should be green when it finishes, see ongoing build log

@StefanieSenger

StefanieSenger commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

I actually wanted to see this result, since there was a second failure similar to pandas-dev/pandas#66018 in the same test.

If I understand correctly, then we'll notice the nighly build fail for emscripten/pyodide in case it was not directly caused by the fix in this PR. Edit: oh yes, or the ongoing build log.

@StefanieSenger
StefanieSenger deleted the xfail_wasm_multithreaded branch July 23, 2026 11:19
@StefanieSenger

StefanieSenger commented Jul 23, 2026

Copy link
Copy Markdown
Member Author

CI failed (here). Seems to be the same error as on pandas. I will try to do a similar fix.

@lesteve

lesteve commented Jul 23, 2026

Copy link
Copy Markdown
Member

Yup seems similar, thanks. I'll try to take a look next week at your next PR. If CI is green and the error is similar to pandas, another maintainer can definitely also feel confident enough to merge your PR 🤞.

@StefanieSenger

StefanieSenger commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Great, I will link your comment on the PR description.
Enjoy life in the meantime.

@StefanieSenger StefanieSenger mentioned this pull request Jul 23, 2026
Merged
@github-project-automation github-project-automation Bot moved this to Done in Labs Jul 27, 2026
prady0t pushed a commit to prady0t/scikit-learn that referenced this pull request Sep 2, 2026
@StefanieSenger @prady0t
MNT Xfail multithreaded test on WASM (scikit-learn#34555)
3df6d24
@jeremiedbb jeremiedbb mentioned this pull request Sep 8, 2026
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lesteve lesteve lesteve approved these changes

Assignees

No one assigned

Labels

module:neighbors No Changelog Needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI Pyodide failure RuntimeError: can't start new thread

2 participants

@StefanieSenger @lesteve