Thanks to visit codestin.com
Credit goes to github.com

Skip to content

CI Switch back to using cython dev in scipy-dev build - #34579

Merged
lesteve merged 1 commit into
scikit-learn:mainfrom
DeaMariaLeon:cython
Jul 27, 2026
Merged

CI Switch back to using cython dev in scipy-dev build#34579
lesteve merged 1 commit into
scikit-learn:mainfrom
DeaMariaLeon:cython

Conversation

@DeaMariaLeon

Copy link
Copy Markdown
Member

Reference Issues/PRs

Reverts #34526
Cython has been fixed, so temporary work-around is not needed: #34525 (comment)

Any other comments?

@lesteve

@DeaMariaLeon DeaMariaLeon moved this to In progress in Labs Jul 27, 2026
@DeaMariaLeon DeaMariaLeon moved this from In progress to PR waiting for reviews in Labs Jul 27, 2026
@jeremiedbb

Copy link
Copy Markdown
Member

I believe we can also revert #34533

@lesteve lesteve left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's merge this one!

I double-checked the scipy-dev build log and it does install Cython from source and the CI is green.

@lesteve lesteve changed the title CI Revert temporary work-around for cython issue CI Switch back to using cython dev in scipy-dev build Jul 27, 2026
@lesteve
lesteve merged commit 7f0f599 into scikit-learn:main Jul 27, 2026
42 checks passed
@github-project-automation github-project-automation Bot moved this from PR waiting for reviews to Done in Labs Jul 27, 2026
@lesteve

lesteve commented Jul 27, 2026

Copy link
Copy Markdown
Member

I believe we can also revert #34533

If I followed correctly the trail in cython/cython#7852, I think we need to wait for Cython 3.2.10 to be released put please double-check. Only then then can we require cython>=3.2.10 and remove all the work-arounds we have in multiple places (lock-files, pyproject.toml, maybe other things).

Anyone should feel free to open a tracking issue as well!

@jeremiedbb

Copy link
Copy Markdown
Member

Ah right it's not released yet, only available in nightly builds.

@DeaMariaLeon
DeaMariaLeon deleted the cython branch July 27, 2026 13:35
prady0t pushed a commit to prady0t/scikit-learn that referenced this pull request Sep 2, 2026
@jeremiedbb jeremiedbb mentioned this pull request Sep 8, 2026
14 tasks
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Sep 8, 2026
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Sep 9, 2026
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants