CI exclude cython 3.2.9 as well - #34584
Merged
lesteve merged 1 commit intoJul 27, 2026
Merged
Conversation
betatim
approved these changes
Jul 27, 2026
Member
|
Let's merge this and trigger the lock-file update via |
Member
|
For the record, in an ideal world, I think I find the update lock-files in PR more work but cleaner (you make sure in the PR that it actually works). In this case, the feeling is that we understand the problem well enough so that the CI will be green with a somewhat high-enough probability 🤞. For now the workflow trying to update the |
prady0t
pushed a commit
to prady0t/scikit-learn
that referenced
this pull request
Sep 2, 2026
jeremiedbb
added a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Sep 8, 2026
jeremiedbb
added a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Sep 9, 2026
jeremiedbb
added a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cython/cython#7846 will be released in 3.2.10 so the current exclusion pattern still makes the lock file updates fail.
I can either include the new lock files here or manually trigger the bot regenerate the lock files after we merge this (I prefer the latter)
cc/ @lesteve