MNT Remove the None option for ScoringMonitor's scoring argument - #34590
Merged
Conversation
Contributor
Author
|
Since the callbacks are documented as experimental, I believe this change does not need a deprecation cycle. |
jeremiedbb
reviewed
Jul 30, 2026
Member
not a deprecation, but we should add a changelog entry to signal the API change still. |
Member
|
Looks like we didn't have any test for scoring=None :) |
Co-authored-by: Jérémie du Boisberranger <[email protected]>
…rn into no_default_scorer
jeremiedbb
reviewed
Jul 31, 2026
| @@ -0,0 +1,3 @@ | |||
| - In :class:`callback.ScoringMonitor`, the option to provide `scoring=None` to have the | |||
| default scorer of the estimator has been removed. | |||
| By :user:`François Paugam <FrancoisPgm>`. | |||
Member
There was a problem hiding this comment.
I'd name that file 34590.api.rst. It is an api change. Also, we're not mapping mnt to anything :)
jeremiedbb
approved these changes
Jul 31, 2026
jeremiedbb
left a comment
Member
There was a problem hiding this comment.
LGTM besides the changelog file name.
prady0t
pushed a commit
to prady0t/scikit-learn
that referenced
this pull request
Sep 2, 2026
…kit-learn#34590) Co-authored-by: Jérémie du Boisberranger <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Requested in the review of #34137
What does this implement/fix? Explain your changes.
Passing
scoring=NonetoScoringMonitormade it possible to use the estimator's default scorer. But this required some annoying workarounds, especially when the same callback is attached to multiple estimators. It also introduces complexity when trying to incorporate metadata routing in callbacks, as is done in #34137. Thus it was proposed to drop this niche case and remove thescoring=Noneoption.Any other comments?
ping @jeremiedbb