FIX indexable with dataframes - #34605
Merged
Merged
Conversation
jeremiedbb
approved these changes
Jul 31, 2026
Member
|
just pushed a doc build to be sure 😄 |
jeremiedbb
enabled auto-merge (squash)
July 31, 2026 12:52
prady0t
pushed a commit
to prady0t/scikit-learn
that referenced
this pull request
Sep 2, 2026
Co-authored-by: Virgil Chan <[email protected]> Co-authored-by: Jérémie du Boisberranger <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fix bug introduced in #33959.
What does this implement/fix? Explain your changes.
Keep input type = output type for dataframes in indexable, i.e. no conversion to narwhals.
AI usage disclosure
None
Any other comments?
@jeremiedbb You were right in #33959. It is not so much the public
indexablebut its use in CV tools that would then pass narwhals df to estimators which have no control over.