Thanks to visit codestin.com
Credit goes to github.com

Skip to content

MNT Add "introduce yourself" to issue template - #34676

Merged
lesteve merged 4 commits into
scikit-learn:mainfrom
lesteve:issue-template-add-introduce-yourself
Aug 13, 2026
Merged

MNT Add "introduce yourself" to issue template#34676
lesteve merged 4 commits into
scikit-learn:mainfrom
lesteve:issue-template-add-introduce-yourself

Conversation

@lesteve

@lesteve lesteve commented Aug 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

This is useful to get an idea about the human behind the contribution. We already have something like this for the PR template. This adds a similar section to the different issue templates as well.

For example, you get good vibes when it is filled in a reasonable manner, e.g. in #34547 and you get not so good vibes when it is not filled at all (often) or with what seems a somewhat generic statement like in #34309.

An example of a recent issue, where I was a bit like, "but come on what is your motivation" #34615 it looks like you first opened a PR which got closed, and then opened an issue because we told you to.

Also I think it makes sense to have this filled even for people that have already contributed a few times, so I removed the mention of first-time contributor in the PR template.

cc @cakedev0 who reminded me this "Introduce yourself" section even existed in the PR template, I had completely forgotten 😅.

betatim
betatim approved these changes Aug 7, 2026
View reviewed changes

@betatim betatim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it.

This is one of these "super easy to revert" things, so I think we should try it and see what happens. No need to hypothesis about the pros and cons

jeremiedbb
jeremiedbb approved these changes Aug 7, 2026
View reviewed changes
Comment thread .github/PULL_REQUEST_TEMPLATE.md Outdated
Comment on lines 29 to 31
<!-- Especially if you are new to the scikit-learn community, please introduce yourself. How do you
use scikit-learn, what prompted you to make this contribution? Getting to know you
helps us build trust in your judgement and welcome you into the community.

@jeremiedbb jeremiedbb Aug 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not covered by linters but now the line is longer than 88 chars

Comment thread .github/PULL_REQUEST_TEMPLATE.md

#### First time contributor introduction
<!-- If you are new to the scikit-learn community, please introduce yourself. How do you
#### Introduce yourself

@jeremiedbb jeremiedbb Aug 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be somewhat annoyed if I was asked to repeat that several time when contributing to a given project, wouldn't you be ? That's why we asked it for first contributions only. But if you think that it's needed, why not.

@lesteve lesteve Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't find this annoying personally, if I am trying to contribute to a new project, I'll try to follow its rules.

This requires the issue/PR author to make a small effort (maybe 2-3 minutes to write a few lines of introduction, maybe less if you have already written one not so long ago).

If the issue/PR author doesn't have this 2-3 minutes to spend on writing a few lines of introduction, there is no reason I will spend 10-15 minutes to have an opinion whether his/her contribution makes basic sense.

Also, as a maintainer I definitely don't want to have to chase all the issues/PRs a user has opened to find the one where he/she has written a few words of introduction.

@lesteve

lesteve commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

So the linting failed with the following error build log

Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/importlib/metadata/__init__.py", line 563, in from_name
    return next(cls.discover(name=name))
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
StopIteration

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/importlib/metadata/__init__.py", line 1009, in version
    return distribution(distribution_name).version
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/importlib/metadata/__init__.py", line 982, in distribution
    return Distribution.from_name(distribution_name)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/importlib/metadata/__init__.py", line 565, in from_name
    raise PackageNotFoundError(name)
importlib.metadata.PackageNotFoundError: No package metadata was found for pyrefly

I merged main hoping this will go away. Edit: it does go away by merging main.

This was referenced Aug 11, 2026
Merged
Closed
@lesteve

lesteve commented Aug 13, 2026

Copy link
Copy Markdown
Member Author

Let's try this and iterate!

@lesteve
lesteve merged commit eb804e1 into scikit-learn:main Aug 13, 2026
38 checks passed
@lesteve
lesteve deleted the issue-template-add-introduce-yourself branch August 13, 2026 03:47
prady0t pushed a commit to prady0t/scikit-learn that referenced this pull request Sep 2, 2026
@lesteve @prady0t
MNT Add "introduce yourself" to issue template (scikit-learn#34676)
fbccbf2
@jeremiedbb jeremiedbb mentioned this pull request Sep 8, 2026
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@betatim betatim betatim approved these changes
@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lesteve @betatim @jeremiedbb