MNT bump array-api-extra to v0.11.1 - #34739
Conversation
Daniel15568
left a comment
There was a problem hiding this comment.
Changes looks internally consistent, I checked that the vendoring version and package version match and don't see sklearn-specific modifications that need changes.
Checked the new device comparison in the vendored testing helpers. Defaulting check_device=True is a behavioral change, but it seems appropriate for Array API assertions and is explicitly disableable.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
betatim
left a comment
There was a problem hiding this comment.
LGTM. Let's wait a bit to hear about the Intel CI failure, and then merge this
|
@cakedev0, friendly ping, could we run the |
|
I am going to merge this one. IMO, Intel is a bit experimental like free-threaded or Pyodide for which the CI doesn't run by default. If something break there, someone will open a follow-up issue/PR, we should not wait for them before merging a PR. |
Co-authored-by: Virgil Chan <[email protected]>
Co-authored-by: Virgil Chan <[email protected]>
Co-authored-by: Virgil Chan <[email protected]>
Co-authored-by: Virgil Chan <[email protected]>
@OmarManzoor FYI