FIX Have progressbar timers stop when task is finished in meta-estimators. - #34746
Merged
jeremiedbb merged 2 commits intoAug 24, 2026
Merged
Conversation
Daniel15568
suggested changes
Aug 14, 2026
Daniel15568
left a comment
There was a problem hiding this comment.
Could you add a regression test covering this behavior? In particular, it would be useful to verify that once a task is finished, advancing the clock does not change the rendered elapsed time.
StefanieSenger
approved these changes
Aug 24, 2026
StefanieSenger
left a comment
Member
There was a problem hiding this comment.
Great, thank you @FrancoisPgm.
I don't think we need a regression test for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
N/A
What does this implement/fix? Explain your changes.
When using a
ProgressBarwithmax_propagation_depth> 0 in a meta-estimators, the timer of bars that are full continue to run while the following bars are filling up (see GIF below). This PR fixes this behaviour simply by usingtask.finished_timerather thantask.elapsedwhen updating the finished tasks' timer.Any other comments?
ping @jeremiedbb