MAINT enable check_array_api_mixed_inputs for PCA - #34771
Merged
lesteve merged 1 commit intoAug 19, 2026
Conversation
check_array_api_mixed_inputs for PCA
lesteve
enabled auto-merge (squash)
August 19, 2026 05:27
lesteve
approved these changes
Aug 19, 2026
Member
|
For completeness I edited your PR description because it doesn't seem like this should close #28668? |
Member
Author
|
Thanks for the merge. I think it was the last XFAIL marker for the common test introduced to enforce what is described in #28668. |
prady0t
pushed a commit
to prady0t/scikit-learn
that referenced
this pull request
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xref: #28668.
Locally the check passes (and this is not surprising since PCA is unsupervised and our current implementation does not support
sample_weight). I think we should not have marked this as XFAIL when introducing the PR for this new check.