CI Add Codespell to linters an removed codespell actions - #34773
Conversation
|
Merging the sphinx-lint PR created conflicts ... I think we have instructions in our doc somewhere that are trying to help with lock-file conflicts https://scikit-learn.org/stable/developers/contributing.html#resolve-conflicts-in-lock-files. |
I saw this comment too late (after my latest push). EDIT: I may need to do "python build_tools/update_environments_and_lock_files.py" again |
lesteve
left a comment
There was a problem hiding this comment.
This looks good. The only thing we are "losing" IIRC is that the codespell-project/codespell-problem-matcher action was supposed to do inline annotations inside the diff, not sure if I have ever seen doing this.
I prefer to have the linter fail and the automatic comment like the other linters.
For more context see #34766 where basically I think what happened codespell got an update and all the lint CI in PRs broke. With codespell being part of our linters, there is a lock-file and this would not happen.
|
Failures are unrelated to this PR. |
|
Thanks, I restarted the failing build and merged. You may know this but you can always push an empty commit to trigger the full CI which may get your CI green if the issue is not deterministic. |
|
Thank you. |
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Add Codespell to linters and removed action
AI usage disclosure
I used AI assistance for:
Any other comments?
@lesteve