You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What does this implement/fix? Explain your changes.
Updates maint_tools/update_tracking_issue.py to use PyGithub's current
authentication API. The script was still using the deprecated Github(token) constructor, which raises a DeprecationWarning in CI.
This switches to the auth=Auth.Token(token) pattern, matching what
other scripts in the repo already use.
Introduce yourself
Hi, I'm Luke, a CS student at Swansea University working towards a career
in cyber/ML for defence. This is one of my first contributions to
scikit-learn, thanks for the pointer to a good first issue, lesteve!
AI usage disclosure
I used AI assistance for:
Documentation (including examples)
The AI use was limited to reorganising and titling sections in my personal
university notes/project files in Word, for easier reference, not for
generating or researching this specific fix. The fix itself came from my
own prior notes and was implemented directly by me.
The pull request addresses an existing issue that is ready for contribution (e.g. not tagged as 'Needs Triage', 'Needs Decision', ...). If you are proposing a new feature, please open an issue to discuss it first.
There are no other open pull requests already targeting the same issue.
You have followed the pull request checklist. In particular, linting and tests should pass.
Thanks @lesteve! Good spot, I'll open a follow-up PR applying the same auth=Auth.Token(...) change to .github/scripts/first-time-contributor.py and .github/scripts/label_title_regex.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #34639
What does this implement/fix? Explain your changes.
Updates
maint_tools/update_tracking_issue.pyto use PyGithub's currentauthentication API. The script was still using the deprecated
Github(token)constructor, which raises aDeprecationWarningin CI.This switches to the
auth=Auth.Token(token)pattern, matching whatother scripts in the repo already use.
Introduce yourself
Hi, I'm Luke, a CS student at Swansea University working towards a career
in cyber/ML for defence. This is one of my first contributions to
scikit-learn, thanks for the pointer to a good first issue, lesteve!
AI usage disclosure
I used AI assistance for:
The AI use was limited to reorganising and titling sections in my personal
university notes/project files in Word, for easier reference, not for
generating or researching this specific fix. The fix itself came from my
own prior notes and was implemented directly by me.
Any other comments?
Happy to make any adjustments needed.