-
-
Notifications
You must be signed in to change notification settings - Fork 27.4k
PRF Ridge - centering trick for cholesky solver #34793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cakedev0
wants to merge
17
commits into
scikit-learn:main
Choose a base branch
from
cakedev0:ridge/optim_cholesky
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+76
−14
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
39b8648
centering trick & fast mean
cakedev0 ffc4331
fast assert finite
cakedev0 71ccc71
Merge remote-tracking branch 'upstream/main' into ridge/optim_cholesky
cakedev0 0714fb9
FIX Ridge: don't skip centering when array API dispatch forces solver…
cakedev0 fe354e2
iter: quite ugly...
cakedev0 88b0aa8
prettier
cakedev0 c7dc619
iter
cakedev0 4c4b330
Merge remote-tracking branch 'upstream/main' into ridge/optim_cholesky
cakedev0 2fcb2fb
remove low-impact optims
cakedev0 19a23ea
Merge remote-tracking branch 'upstream/main' into ridge/optim_cholesky
cakedev0 dbc32bb
iter comments
cakedev0 2053577
cleanup
cakedev0 8b64627
more cleanup
cakedev0 5b06fe6
Merge remote-tracking branch 'upstream/main' into ridge/optim_cholesky
cakedev0 29a3ee3
inline comment
cakedev0 33d02cb
revert return_solver
cakedev0 e191db3
Merge branch 'main' into ridge/optim_cholesky
ogrisel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to reviewers: this addition is needed because I now pass
check_input=Falseto_preprocess_datawhich would have done this logic.