MNT Raise ValueError if local_filename is not a plain filename in sklearn.datasets.fetch_file - #34815
Merged
Merged
Conversation
DeaMariaLeon
marked this pull request as ready for review
August 25, 2026 16:45
sklearn.datasets.fetch_filelocal_filename is a plain filename in sklearn.datasets.fetch_file
Member
|
Since this is a small change in behaviour, even if I suspect this will not affect anyone, please add a changelog ("Fix" category) saying something like:
|
lesteve
reviewed
Aug 26, 2026
lesteve
left a comment
Member
There was a problem hiding this comment.
A few comments, but LGTM otherwise.
local_filename is a plain filename in sklearn.datasets.fetch_filesklearn.datasets.fetch_file local_filename argument is not a plain filename
sklearn.datasets.fetch_file local_filename argument is not a plain filenamelocal_filename is not a plain filename in sklearn.datasets.fetch_file
lesteve
reviewed
Aug 26, 2026
Member
Author
|
Thank you! |
prady0t
pushed a commit
to prady0t/scikit-learn
that referenced
this pull request
Sep 2, 2026
…sklearn.datasets.fetch_file` (scikit-learn#34815)
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Sep 8, 2026
…sklearn.datasets.fetch_file` (scikit-learn#34815)
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Sep 8, 2026
…sklearn.datasets.fetch_file` (scikit-learn#34815)
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Sep 8, 2026
…sklearn.datasets.fetch_file` (scikit-learn#34815)
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Sep 9, 2026
…sklearn.datasets.fetch_file` (scikit-learn#34815)
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Sep 9, 2026
…sklearn.datasets.fetch_file` (scikit-learn#34815)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
None
What does this implement/fix? Explain your changes.
Raise when
local_fileis a path.Introduce yourself
AI usage disclosure
I used AI assistance for:
Any other comments?
@lesteve
For maintainers see https://github.com/scikit-learn/scikit-learn/security/advisories/GHSA-m2ff-mg72-q9p4 for more context.