MNT replace array-api-extra nan reduction functions - #34854
Merged
Conversation
ogrisel
approved these changes
Aug 31, 2026
ogrisel
left a comment
Member
There was a problem hiding this comment.
Nice :)
Let me start an Intel GPU run on this branch: https://github.com/probabl-ai/scikit-learn-intel-workflow/actions/runs/33380159538
Will merge if all green.
Contributor
Author
|
@ogrisel Seems like the intel workflow got cancelled |
Member
|
That's expected if @cakedev0's laptop is not online. But that's fine. The other runs are green. Edit: Actually no, that's not expected that they are all cancelled. I ll give it a look later. |
Member
|
I think the Intel GPU won't be available for a few hours because it is being used by long running benchmarking tasks. Let's merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Follow up of #34851
What does this implement/fix? Explain your changes.
Uses the array-api-extra functions
nanminnanmaxnanmeannansumand removes the private utilities in
_array_apiutils.Any other comments?
CC: @ogrisel. I tried looking at
covtoo but that implementation is slightly different from what we have in our utils considering we have an additional parametermeanthat thearray-api-extraimplementation does not.