-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
[MRG+1] Add dependence on max_features to docstring #4042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As requested in 4032#issuecomment-68478422.
Terms that were ignored because they either | ||
- occurred in too many documents (`max_df`) | ||
- occurred in too few documents (`min_df`) | ||
- were cut off by feature selection (`max_features`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the bullets render fine in the sphinx generated doc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@agramfort I think it doesn't render properly...
Ref : From scipy's documentation... A similar bulleted list in the documentation was changed to this and later to this...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding 2 spaces before -
should fix it... Ref gradient_boosting.GradientBoostingClassifier
documentation and the corresponding source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need to prefix it with spaces, but may need a blank line before the list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lmichelbacher please run:
pip install -U sphinx
cd doc
make html-noplot
and then check the rendered documentation in the doc/_build/
folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ogrisel Thanks for the tip.
I've checked out the patch-2 branch on lmichelbacher/scikit-learn and ran the commands. The Python source file (text.py) does have the modified docstring but for some reason the built docs don't reflect that.
I'm not familiar with sphinx so it might be some noob mistake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to make sure that the development version of scikit-learn is the one used when building the doc. To do so, you can run python setup.py develop
in your source folder. Once the doc is build you can uninstall and reinstall the latest stable version of scikit-learn if you prefer not to use the development version otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, that worked.
I've copied the structure of the docstring from the example above but in my case the line above the bullets is rendered in bold. As soon as I've figured out how to fix this I'll amend the commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need a newline before the bullets.
Is there any way to change the email on the last commit? My user.email/user.name wasn't set up correctly. |
|
@jnothman does this work even for commits that have already been pushed? |
The |
New** git magic, cool. I'll do that. ** new to me ;) |
Without the extra line, the headline is rendered in bold.
LGTM 👍 |
LGTM. Merging. Thanks! |
[MRG+1] Add dependence on max_features to docstring
As requested in #4032 (comment).