[MRG] FIX/TST boundary cases in dbscan #4073
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -174,6 +175,17 @@ def test_pickle(): | |||
| assert_equal(type(pickle.loads(s)), obj.__class__) | |||
|
|
|||
|
|
|||
| def test_bounaries(): | |||
aec25bb to
495c146
Compare
|
This should now be testable, right? |
495c146 to
cdb0577
Compare
Rather the tests were written elsewhere with a different patch. This is now rebased and ready for review. |
|
the case with no core samples fails... |
|
Of course I reviewed #4052, but what basis did we have for thinking I've made that test more certain. |
|
Sorry, that was a hacky test. It probably came from some example that was failing at the time. |
| core, _ = dbscan([[0], [1]], eps=2, min_samples=2) | ||
| assert_in(0, core) | ||
| # ensure eps is inclusive of circumference | ||
| core, _ = dbscan([[0], [1], [1]], eps=1, min_samples=2) |
There was a problem hiding this comment.
Maybe a stupid question but why do you need [1] twice?
alexsavio
pushed a commit
to alexsavio/scikit-learn
that referenced
this pull request
Mar 9, 2015
rasbt
pushed a commit
to rasbt/scikit-learn
that referenced
this pull request
Apr 6, 2015
yarikoptic
added a commit
to yarikoptic/scikit-learn
that referenced
this pull request
Jul 11, 2015
* tag '0.16b1': (1589 commits) 0.16.X branching, version 0.16b1 Fix scikit-learn#4351. Rendering of docs in MinMaxScaler. Fix rebase conflict MAINT use canonical PEP-440 dev version consistently Adding fix for issue scikit-learn#4297, isotonic infinite loop DOC deprecate random_state for DBSCAN FIX/TST boundary cases in dbscan (closes scikit-learn#4073) Do not shuffle in DBSCAN (warn if `random_state` is used). Update docstring predict_proba() Update documentation of predict_proba in tree module add scipy2013 tutorial links to presentations on website. TST boundary handling in LSHForest.radius_neighbors ENH improve docstrings and test for radius_neighbors models use a pipeline for pre-processing feature selection, as per best practise DOC remove unnecessary backticks in CONTRIBUTING. ENH no need for tie breaking jitter in calibration Implement "secondary" tie strategy in isotonic. Adding unit test to cover ties/duplicate x values in Isotonic Regression re: issue scikit-learn#4184 MAINT fix typo pyagm -> pygamg in SkipTest STYLE trailing spaces ...
yarikoptic
added a commit
to yarikoptic/scikit-learn
that referenced
this pull request
Jul 11, 2015
* releases: (1589 commits) 0.16.X branching, version 0.16b1 Fix scikit-learn#4351. Rendering of docs in MinMaxScaler. Fix rebase conflict MAINT use canonical PEP-440 dev version consistently Adding fix for issue scikit-learn#4297, isotonic infinite loop DOC deprecate random_state for DBSCAN FIX/TST boundary cases in dbscan (closes scikit-learn#4073) Do not shuffle in DBSCAN (warn if `random_state` is used). Update docstring predict_proba() Update documentation of predict_proba in tree module add scipy2013 tutorial links to presentations on website. TST boundary handling in LSHForest.radius_neighbors ENH improve docstrings and test for radius_neighbors models use a pipeline for pre-processing feature selection, as per best practise DOC remove unnecessary backticks in CONTRIBUTING. ENH no need for tie breaking jitter in calibration Implement "secondary" tie strategy in isotonic. Adding unit test to cover ties/duplicate x values in Isotonic Regression re: issue scikit-learn#4184 MAINT fix typo pyagm -> pygamg in SkipTest STYLE trailing spaces ... Conflicts: sklearn/externals/joblib/__init__.py sklearn/externals/joblib/numpy_pickle.py sklearn/externals/joblib/parallel.py sklearn/externals/joblib/pool.py
yarikoptic
added a commit
to yarikoptic/scikit-learn
that referenced
this pull request
Jul 11, 2015
* dfsg: (1589 commits) 0.16.X branching, version 0.16b1 Fix scikit-learn#4351. Rendering of docs in MinMaxScaler. Fix rebase conflict MAINT use canonical PEP-440 dev version consistently Adding fix for issue scikit-learn#4297, isotonic infinite loop DOC deprecate random_state for DBSCAN FIX/TST boundary cases in dbscan (closes scikit-learn#4073) Do not shuffle in DBSCAN (warn if `random_state` is used). Update docstring predict_proba() Update documentation of predict_proba in tree module add scipy2013 tutorial links to presentations on website. TST boundary handling in LSHForest.radius_neighbors ENH improve docstrings and test for radius_neighbors models use a pipeline for pre-processing feature selection, as per best practise DOC remove unnecessary backticks in CONTRIBUTING. ENH no need for tie breaking jitter in calibration Implement "secondary" tie strategy in isotonic. Adding unit test to cover ties/duplicate x values in Isotonic Regression re: issue scikit-learn#4184 MAINT fix typo pyagm -> pygamg in SkipTest STYLE trailing spaces ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3994 handled the
min_samplesboundary case differently to the prior DBSCAN implementation. This is now clarified in the docs. Unfortunately, when properly testing boundary cases, I found the inconsistency reported at #4072. I fix it here for 'brute' search without tests, pending a complete patch for #4072.