-
-
Notifications
You must be signed in to change notification settings - Fork 26.3k
[WIP] Earth (MARS), continuation #4341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ing" This reverts commit 87db631.
Getting recent changes from scikit-learn people.
I thought they were working before. Maybe I ran the wrong tests or something.
…klearn and to work with gen_rst
1. Added allow_linear argument 2. Fixed a bug in the way endspan argument was processed 3. Fixed a bug in the way sample_weights were being applied 4. Added simple test case for 3 (test needs to be improved, may be platform dependent) 5. Fixed a typo where min_search_points was accidentally min_searh_points
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure lines are less than 80c everywhere even in the docstring / doc
have a look at travis failure |
Closing given that PyEarth is in sklearn-contrib; that this PR hasn't been updated in |
Continuation Of #2285 here.