Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[MRG + 2] FIX ransac output shape, add test for regressor output shapes #4739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2015

Conversation

amueller
Copy link
Member

Adds a tests for regressor output shapes.
I'm not sure if it is strict enough. I'm not sure what happens with y.shape = (n_samples, 1) currently.
This is to make sure that we don't return (n_samples, 1) if the training data was (n_samples,).

Inspired by @naught101's comment here

@arjoly
Copy link
Member

arjoly commented May 20, 2015

Lgtm

@amueller amueller changed the title [MRG] FIX ransac output shape, add test for regressor output shapes [MRG + 1] FIX ransac output shape, add test for regressor output shapes May 20, 2015
@ogrisel
Copy link
Member

ogrisel commented May 21, 2015

This looks good. Maybe this requires a whats new entry.

@ogrisel ogrisel changed the title [MRG + 1] FIX ransac output shape, add test for regressor output shapes [MRG + 2] FIX ransac output shape, add test for regressor output shapes May 21, 2015
larsmans added a commit that referenced this pull request May 23, 2015
FIX ransac output shape, add test for regressor output shapes
@larsmans larsmans merged commit da73f5c into scikit-learn:master May 23, 2015
@amueller amueller deleted the regressor_output_shape_test branch May 19, 2017 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants