[MRG + 1] Function transformer rebase #5059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1934501 to
70d31b0
Compare
|
Maybe @larsmans wants to review? |
| if self.validate: | ||
| X = check_array(X, self.accept_sparse) | ||
|
|
||
| return (self.func or _identity)(X, *((y,) if self.pass_y else ())) |
There was a problem hiding this comment.
Nitpick: This should really check for self.func is None. While obscure, it's possible for an object to be boolean False and still callable.
|
Btw, while I'm fine with merging this as-is, I actually prefered the version with |
CallableTransformer allows a user to convert a standard python callable into a transformer for use in a Pipeline.
Makes `pass_y` an argument to FunctionTransformer to indicate that the labels should be passed to the wrapped function.
70d31b0 to
73532be
Compare
73532be to
a2a2d83
Compare
| from nose.tools import assert_equal | ||
| import numpy as np | ||
|
|
||
| from ..function_transformer import FunctionTransformer |
There was a problem hiding this comment.
Test should use public import (full path). In fact, I think the module should be called _function_transformer so people don't import it directly.
|
Thanks @larsmans. Are you making the module private or should I? |
|
I'm on it. |
|
Thanks. We also need a whatsnew. |
|
👍 |
|
🍻 indeed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #4798. Should be good to go.