Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[WIP] improving equality test in sklearn's clone function #5525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[WIP] improving equality test in sklearn's clone function #5525

wants to merge 1 commit into from

Conversation

dohmatob
Copy link
Contributor

This PR addresses issue #5522.

@dohmatob dohmatob mentioned this pull request Oct 22, 2015
Closed
ogrisel
ogrisel reviewed Oct 22, 2015
View reviewed changes
sklearn/tests/test_base.py Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather raise a SkipTest('pandas required') exception to make it more explicit that this test was not run.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes indeed. thanks.

@ogrisel
Copy link
Member

ogrisel commented Oct 22, 2015

clone would have the same problem with a numpy array passed as an input parameter right? Testing this would not require the dependency on pandas at test time.

@dohmatob
Copy link
Contributor Author

@ogrisel: No, ndarrays are handled separately in the function.

amueller
amueller reviewed Oct 22, 2015
View reviewed changes
sklearn/tests/test_base.py Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have a mock dataframe object.

@amueller
Copy link
Member

I am not sure I understand why this works. maybe @GaelVaroquaux can say something about it. Shouldn't we be deepcopying the dataframe? We deepcopy numpy arrays, right?

GaelVaroquaux
GaelVaroquaux reviewed Oct 22, 2015
View reviewed changes
sklearn/base.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good (although it took me a minute to realize why :) )

@GaelVaroquaux
Copy link
Member

We deepcopy everything that is not an estimator (line 49 of base.py).

@amueller
Copy link
Member

yeah but why is is true after deepcopying something?

@GaelVaroquaux
Copy link
Member

GaelVaroquaux commented Oct 22, 2015 via email

@amueller
Copy link
Member

Argh... so both me and @GaelVaroquaux where a little unclear on what is happening here. I'll post the correct fix in a minute.

@amueller amueller mentioned this pull request Oct 23, 2015
Merged
@ogrisel
Copy link
Member

ogrisel commented Oct 23, 2015

I think #5540 is a better fix.

@ogrisel ogrisel changed the title [WIP] improving equality test inf sklearn's cloning function [WIP] improving equality test in sklearn's clone function Oct 23, 2015
@dohmatob dohmatob closed this Nov 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dohmatob @ogrisel @amueller @GaelVaroquaux