[MRG+1] Raise appropriate error if y is sparse #5542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fine for me. But this means trees cannot be used for multi-label? |
|
You can do it for multi-label with a dense array, but this is not (and has never) been possible for sparse y. Note that it's possible to implement a criterion that supports a sparse y. |
|
Oh yeah, right, Okay then. +1 |
|
ping @jmschrei @MechCoder |
|
LGTM. Would be great if you could look at #5497 |
amueller
added a commit
that referenced
this pull request
Oct 23, 2015
[MRG+1] Raise appropriate error if y is sparse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ping @rvraghav93 @glouppe @jnothman