[MRG + 1] BF: not mutating alpha in VBGMM, using alpha_ instead #5551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sklearn/mixture/dpgmm.py
Outdated
There was a problem hiding this comment.
this needs to be a property, or set in fit.
If tests pass with setting it in fit, that would be preferable.
|
ping @amueller |
|
LGTM, thanks |
|
@agramfort ? ;) |
There was a problem hiding this comment.
I don't think we need a property here. Just add the alpha_ attribute.
|
This class has too many problems and we have deprecated it #6998. |
|
@tguillemot I know. but this is critical to make #5540 work, which I really want to have in 0.18 |
|
@amueller Ok. I haven't noticed it. |
Merged
|
fixed in #7028 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #5547