[MRG] load_breast_cancer dataset: added return_X_y option #7152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sklearn/datasets/base.py
Outdated
| Parameters | ||
| ---------- | ||
| return_X_y : boolean, deafult=True |
Contributor
There was a problem hiding this comment.
also I believe default should be False?
Contributor
|
You should also edit your previous entry in whats_new.rst to reflect the changes you've made here. |
Contributor
Author
|
Fixed. |
doc/whats_new.rst
Outdated
| - Added new return type ``(data, target)`` : tuple option to | ||
| :func:`load_iris` dataset. | ||
| :func:`load_iris` dataset, :func:`load_breast_cancer` dataset | ||
| (`#7049 <https://github.com/scikit-learn/scikit-learn/pull/7049>`_) by |
Contributor
There was a problem hiding this comment.
im inclined to have it formatted as such:
Add new return option to load (link to pr), loader2 (link to another pr), etc.
Contributor
Author
There was a problem hiding this comment.
Yeah, it's a better formatting. Fixed.
Contributor
|
LGTM, thanks! |
Member
|
thx @manu-chroma |
TomDLT
pushed a commit
to TomDLT/scikit-learn
that referenced
this pull request
Oct 3, 2016
…rn#7152) * added return_X_y option to breast_cancer_dataset, tests included * fix typo * update whats_new * removed extra space * improved whats_new changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Partially Fixes #6670
What does this implement/fix? Explain your changes.
load_breast_cancerdatasetAny other comments?
Very similar to #7049