[MRG + 1] Remove np.isclose() from ROC curve calculation #7353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think at a minimum, this will require a what's new alerting users to the changed behaviour. Perhaps a non-regression test is also appropriate. Thanks for this. We'll squeeze it into an imminent release, perhaps? |
|
+1 for non-regression test with small values. +1 for 0.18 |
|
Modified an existing test ( |
|
can you rebase please? |
| @@ -387,6 +387,11 @@ Bug fixes | |||
| - Fix :class:`linear_model.ElasticNet` sparse decision function to match | |||
| output with dense in the multioutput case. | |||
|
|
|||
| - :func:`metrics.roc_curve` and :func:`metrics.precision_recall_curve` no | |||
| longer round `y_score` values when creating ROC curves; this was causing | |||
…s_new.rst. Modified a unit test to check for the kind of problems caused by isclose.
9f4aed4 to
d0dd283
Compare
|
Applied @amueller's suggesed fixes to the whatsnew entry, then rebased and squashed. |
|
lgtm |
|
LGTM |
|
Thanks @jblackburne :) |
rsmith54
pushed a commit
to rsmith54/scikit-learn
that referenced
this pull request
Sep 14, 2016
Added a bugfix report to whats_new.rst. Modified a unit test to check for the kind of problems caused by isclose.
TomDLT
pushed a commit
to TomDLT/scikit-learn
that referenced
this pull request
Oct 3, 2016
Added a bugfix report to whats_new.rst. Modified a unit test to check for the kind of problems caused by isclose.
Closed
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
Added a bugfix report to whats_new.rst. Modified a unit test to check for the kind of problems caused by isclose.
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
Added a bugfix report to whats_new.rst. Modified a unit test to check for the kind of problems caused by isclose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the use of
np.isclose()when finding indices wherey_scorechanges during calculation of ROC curves. It is equivalent to changing the tolerance parameters ofiscloseto 0. It is strictly a reversion of #3268.Fixes #3864, as well as dupes #4864 and #6688.
There is relevant discussion on #6693. To me it seemed that the consensus was to take this course of action. Further comments are welcome too.
If this is merged, #6693 can probably be closed as OBE.