-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
[MRG+1] minor link fix for SAG paper. #7523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link to SAG paper in `References` section updated (scikit-learn#7512).
LGTM |
Except
|
dead link of SAG paper in Logistic Regression user guide updated. resolves scikit-learn#7512
SAG paper cited in `Reference` section of docstring(scikit-learn#7512).
4cd8fe8
to
45a7f84
Compare
@jnothman, done. kindly review. 😄 |
TomDLT
pushed a commit
to TomDLT/scikit-learn
that referenced
this pull request
Oct 3, 2016
* Link to SAG paper updated link to SAG paper in `References` section updated (scikit-learn#7512). * Link to SAG paper updated dead link of SAG paper in Logistic Regression user guide updated. resolves scikit-learn#7512 * SAG paper cited in docstring SAG paper cited in `Reference` section of docstring(scikit-learn#7512).
amueller
pushed a commit
to amueller/scikit-learn
that referenced
this pull request
Oct 14, 2016
* Link to SAG paper updated link to SAG paper in `References` section updated (scikit-learn#7512). * Link to SAG paper updated dead link of SAG paper in Logistic Regression user guide updated. resolves scikit-learn#7512 * SAG paper cited in docstring SAG paper cited in `Reference` section of docstring(scikit-learn#7512).
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
* Link to SAG paper updated link to SAG paper in `References` section updated (scikit-learn#7512). * Link to SAG paper updated dead link of SAG paper in Logistic Regression user guide updated. resolves scikit-learn#7512 * SAG paper cited in docstring SAG paper cited in `Reference` section of docstring(scikit-learn#7512).
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
* Link to SAG paper updated link to SAG paper in `References` section updated (scikit-learn#7512). * Link to SAG paper updated dead link of SAG paper in Logistic Regression user guide updated. resolves scikit-learn#7512 * SAG paper cited in docstring SAG paper cited in `Reference` section of docstring(scikit-learn#7512).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #7512
updates link to SAG paper in the LinearRegression user guide.
SAG paper cited in Reference section of docstring of
LogisticRegression
.updates link to SAG paper in References section of
SAG Solvers
.