[MRG + 1] Make common metric tests look nicer #7620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change the tests to yield after performing the _named_check. * Tests affected: -test_averaging_multiclass -test_averaging_multilabel -test_averaging_multilabel_all_zeroes -test_averaging_multilabel_all_ones -test_sample_weight_invariance * File updated: sklearn/metrics/tests/test_common.py
fbf86be to
fac2708
Compare
|
Looks good so far but I think you missed some yields. |
|
@amueller I left them intentionally since they already have clean and nice looking output. What say ? |
|
ok :) |
|
Tested locally. LGTM. Thanks :) |
|
@amueller Thanks. On a side note, what is the meaning of [MRG + 1] ? |
|
http://scikit-learn.org/dev/developers/contributing.html#contributing-pull-requests |
RPGOne
approved these changes
Oct 10, 2016
|
@jnothman I changed the title of PR to +2 assuming RPGOne is a core developer and that he forgot to change the title. Not sure if he is a core developer. |
|
@aashil no he is spamming and / or a bot. |
|
Can one more core developer please review this PR ? Thanks. |
amueller
pushed a commit
to amueller/scikit-learn
that referenced
this pull request
Oct 14, 2016
* Change the tests to yield after performing the _named_check. * Tests affected: -test_averaging_multiclass -test_averaging_multilabel -test_averaging_multilabel_all_zeroes -test_averaging_multilabel_all_ones -test_sample_weight_invariance * File updated: sklearn/metrics/tests/test_common.py
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
* Change the tests to yield after performing the _named_check. * Tests affected: -test_averaging_multiclass -test_averaging_multilabel -test_averaging_multilabel_all_zeroes -test_averaging_multilabel_all_ones -test_sample_weight_invariance * File updated: sklearn/metrics/tests/test_common.py
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
* Change the tests to yield after performing the _named_check. * Tests affected: -test_averaging_multiclass -test_averaging_multilabel -test_averaging_multilabel_all_zeroes -test_averaging_multilabel_all_ones -test_sample_weight_invariance * File updated: sklearn/metrics/tests/test_common.py
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
* Change the tests to yield after performing the _named_check. * Tests affected: -test_averaging_multiclass -test_averaging_multilabel -test_averaging_multilabel_all_zeroes -test_averaging_multilabel_all_ones -test_sample_weight_invariance * File updated: sklearn/metrics/tests/test_common.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #7369
What does this implement/fix? Explain your changes.
Any other comments?
Tests affected:
-test_averaging_multiclass
-test_averaging_multilabel
-test_averaging_multilabel_all_zeroes
-test_averaging_multilabel_all_ones
-test_sample_weight_invariance
File updated: sklearn/metrics/tests/test_common.py