[MRG+1] CircleCI timeout extended #7693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IIRC the CircleCI timeout means that there has been no output for 10 minutes. This should not happen when generating the documentation since most of the examples prints to stdout and should definitely take less than 10 minutes. Having said that I have no clue why some CircleCI builds seem to stall like this. |
|
LGTM |
|
let's see if it helps.. |
amueller
pushed a commit
to amueller/scikit-learn
that referenced
this pull request
Oct 25, 2016
* Circle CI: adding 1h timeout for build_doc.sh * Circle CI: typo + trigger build * CircleCI: trigger build again
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
* Circle CI: adding 1h timeout for build_doc.sh * Circle CI: typo + trigger build * CircleCI: trigger build again
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
* Circle CI: adding 1h timeout for build_doc.sh * Circle CI: typo + trigger build * CircleCI: trigger build again
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
* Circle CI: adding 1h timeout for build_doc.sh * Circle CI: typo + trigger build * CircleCI: trigger build again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the problem of previous CircleCI timeouts.
Recently some CircleCI-builds time out, as
build_tools/circle/push_doc.shtakes too long (30-40 min, default-timeout: 10 min).This PR sets the new timeout to 1 hour (the max. seems to be 2h).
The build fails on my fork, probably because credentials are missing. But the timeout-option seems to be OK.
Thanks for considering this PR.